01439: Uploads do not enforce $EnablePostAuthorRequired

Summary: Uploads do not enforce $EnablePostAuthorRequired
Created: 2019-04-17 11:02
Status: Closed, added for 2.2.117
Category: Bug
From: Petko

Description: From Dfaure: Uploads do not enforce $EnablePostAuthorRequired, here people on pmwiki.org can upload files without providing a name. Cookbook:RecentUploadsLog shows a question mark in the Recent changes. Petko April 17, 2019, at 11:03 AM

I've added to Subversion the variable $EnableUploadAuthorRequired default to $EnablePostAuthorRequired, and an "Author:" field in the upload form, this is now enabled for ?action=upload here and can be downloaded at Subversion (only upload.php changed from 2.2.116).

I have a concern with the "Author" word in the upload form: it means "the wiki author/editor, the person who uploads a file". One could also, and legitimately, understand "the author of the file (like a writer, photographer)" or even "the creator of the object depicted (like a designer, architect, painter...)" who in many cases are people different from the uploader.

So I wonder should we keep the "Author:" label on the upload form, or would it be better to change it to something else like "Uploader:" or "Your name:"? In addition, "Author:" is already translated in many languages, if we change it we need to add more translations. By the way, in French and Bulgarian which I use besides English, there are no good translations for "Uploader".

Please comment. --Petko June 19, 2019, at 05:39 AM

As far as uploading has always been considered as an optional feature I think that using the "Uploader:" label is a good thing. Nevertheless, as uploading and page authoring are often bound activities, the uploader name should be pre-filled with the author one.

--Dfaure June 19, 2019, at 08:54 AM

As translation of 'uploader', I would use the substantiated present participle of the translation of 'upload'. It's not the prettiest word, but suitable.

--MFWolff June 20, 2019, at 07:07 AM

Thank you for this, changed to "Uploader", pre-filled with the wiki author (editor) name. This is translatable in XLPage. --Petko June 30, 2019, at 08:59 AM