00964: Extraneous $seen in pmwiki.php, line 1667

Summary: Extraneous $seen in pmwiki.php, line 1667
Created: 2007-08-09 07:55
Status: Closed : not a bug
Category: Bug
From: EemeliAro
Priority: 1
Version: <= 2.2.0-beta63
OS: any

Description: Line 1667 in function PostRecentChanges of pmwiki.php refers to a variable $seen that isn't referenced anywhere else. Hence the if() statement is never true:

if (@$seen[$rcname]++) continue;

It is referenced at this same moment ($seen++) and becomes 1 if didn't exist. In case another entry in the $RecentChangesFmt array evaluates to the same pagename, the $seen variable will be true and the processing will be skipped. --Petko June 27, 2009, at 02:38 AM