00059: Triple tilde not converted in preview

Summary: Triple tilde not converted in preview
Created: 2004-09-27 15:15
Status: Closed - fixed for 2.2.3
Category: Bug
Priority: 2
Version: 2.0.devel8
OS: <that of the develoment server>

Description: Triple tilde ([[~Pm]]) mark-up works once pages are saved, but they don't show up on the page preview. This makes it very unclear to someone using this feature for the first time that it will work -- this is the purpose of the preview in the first place.

The result of the triple tilde mark-up should show up in the preview.

I originally had it that way (tilde markup gets replaced for the preview), but then had a request to only do the replacement on save and not on preview (see http://pmichaud.com/pipermail/pmwiki-users/2004-June/005590.html). I personally can go either way on this one, so others will have to duke it out. (Of course, whichever isn't the default will be provided as an option.) Pm

This is an issue I don't have a very clear opinion about. Both ways of doing it has advantages.

  • Replacing on preview may be more better for infrequent authors. If it is not replaced, you may think that the triple-tilde syntax does not work.
  • Not replacing on preview give the author a chance to change the Author field after preview.

But if you forget to change the author field, I'm sure you will start remembering it after editing a few pages to get it correct. If I have to choose, I'll go for replace-on-preview. TomCato?

I believe the preview is a WYSIWYG element, so it should display something that looks like the final version and not contain any markup.

Thinking about it, the question of the integrity the interface logic makes replace-on-preview the only sensible option, in my opinion at least. But anything you can switch off is a feature! ;-) Henning

Never mind...I was thinking about this issue from entirely the wrong perspective. It works now -- ~~~ displays as the author signature in the page preview but isn't converted in the edit text to an author signature until the page is actually saved. Let me know if this seems to work here and I'll close the issue. Pm

I think this works ok. TomCato?