01150: Uploads bugs

Summary: Uploads bugs
Created: 2009-10-24 14:14
Status: Closed - added for 2.2.7
Category: Bug
From: Maxim?
Assigned:
Priority: 3
Version: 2.2.6
OS: Apache

Description:

1. Firefox truncates filenames on download if there are spaces. Solution: add quotes.

uploads.php:191

  header("Content-disposition: $DownloadDisposition; filename=\"$upname\"");

2. Downloads through $EnableDirectDownload = 0 get truncated

I was getting small amounts cut off in Firefox 3 and IE8. wget in Linux worked fine. The apparent solution (by trial and error) seemed to be to add:

  header("Connection: close");

although this may be a weirdness for my host.

I added the first suggestion for 2.2.7, after reading this. The second one -- I've never experienced it, and should not be a problem as PmWiki sends a correct Content-length header -- the "Connection: close" header could be added to wikis which require it, in config.php:
if($action=='download') header("Connection: close");
I'm closing this entry; in case it should be further discussed, please reopen it or open a new PITS entry. --Petko October 24, 2009, at 09:46 PM