00829: Reduce diff related spam in history log

Summary: Reduce diff related spam in history log
Created: 2006-11-09 02:54
Status: Open
Category: Bug
From: aa?
Assigned:
Priority:
Version: 2.1.26
OS:

Description: Diffing sometimes creates spam in the history log, claiming the compared texts are not return-terminated. The spam is only visible if you read the saved version of your file (it won't be displayed in a browser).

An easy fix is to change the diff function call site to patch the compared strings with a return. That is, replace the current diff call with this:

    if ($page["time"]>0 && function_exists(@$DiffFunction)) 
      $new["diff:$Now:{$page['time']}:$diffclass"] =
       $DiffFunction($new['text']."\n",@$page['text']."\n");