Recent Changes - Search:

PITS main list

edit sidebar

Main sidebar

PmWiki

pmwiki.org

00749

Summary: $Action skin template values have disappeared.
Created: 2006-06-02 15:14
Status: Closed - fixed in 2.1.10
Category: Bug
From: HaganFox
Assigned:
Priority: 4
Version: 2.1.4 - 2.1.9
OS: N/A

Description: The skin template is not showing values for the $Action skin template variable.

For example, using the default template ?action=edit used to change the title from

    "PmWiki | Main / HomePage "

to

    "PmWiki | PmWiki / PmWiki | Edit"

but now the title doesn't change.


Ick. Some version of PmWiki introduced an {$Action} page variable, which is the value of the current action (i.e., 'edit', 'browse', 'diff', etc.). When introduced, I forgot that it conflicted with the existing $Action variable that was being used in the title.

It seems that reserving "$Action" to be the exact value of ?action= makes more sense overall, so my preference at this point is to change the $Action skin variable to be $ActionTitle, since it's a modified reader-friendly form of $action. This is what I've done on pmwiki.org for the time being.

Comments?

Pm


$ActionTitle works for me.

This might not be worth mentioning, but I think I'd take the trailing space out of the template and replace it with a leading space in the variable.

    <title>$WikiTitle | PITS / 00749 $Action</title>

becomes

    <title>$WikiTitle | PITS / 00749$Action</title>

and

    "| Edit"

becomes

    " | Edit"

--Hagan


Changed to $ActionTitle in 2.1.10. I left the leading space in the template -- at the moment it makes more sense to me there (and it doesn't require a further change).

Pm

Edit - History - Print - Recent Changes - Search
Page last modified on September 10, 2011, at 11:56 AM