Recent Changes - Search:

PmWiki

pmwiki.org

RefCount-Talk


I was looking into the code of scripts/refcount.php to see how it's done.

The code works fine, but unfortunately the used HTML is invalid in two ways:

  1. The HTML specification in there does not match to the one PmWiki uses. PmWiki uses XHTML 1.0 Transitional (see template pub/skins/pmwiki/pmwiki.tmpl), the HTML in refcount.php looks like HTML 4.01 Transitional. The W3C Markup Validation Service therefore returns tons of errors (Test yourself on Main/HomePage). The wrong markup is mainly:
    • Each empty tag like <input >, <br> etc requires an ending it with />.
    • <option> lists must be closed by </option>, same applies to <p>
    • "minimized" attributes like "checked", "selected" etc must be written as "checked='checked'"
  2. There are two other mistakes that need to be fixed:
    • <form> requires an attribute named action; should be $_SERVER['REQUEST_URI'] or similar.
    • <input type='hidden' action='refcount'> is wrong, should be <input type='hidden' name='action' value='refcount' />.

I've created a PITS entry for it.

RRipley, 20110922 8:30pm UTC



This is a talk page for improving PmWiki.RefCount.

Edit - History - Print - Recent Changes - Search
Page last modified on September 22, 2011, at 04:51 PM