01461: incompatible with php 8.0

Summary: incompatible with php 8.0
Created: 2020-12-01 06:14
Status: ToDo
Category: PHP Compatibility
Assigned:
Priority: 4
Version: 2.2.134
OS:

Description: Under php 8.0 pmwiki enters in infinite loop. It's because of change of comparing rules in php 8.0.

In pmwiki.php (line 1580) instead of

  if ($depth == 0) $depth = strlen($depth);
  if ($icol == 0) $icol = strlen($icol);

must be

  if (!is_numeric($depth)) $depth = strlen($depth);
  if (!is_numeric($icol)) $icol = strlen($icol);

Yury Finkel? December 01, 2020, at 06:14 AM